-
Notifications
You must be signed in to change notification settings - Fork 64
sap_hana_install: Rework tags #1138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
berndfinger
merged 7 commits into
sap-linuxlab:dev
from
berndfinger:issue-1137-rework-tags-for-sap_hana_install
Dec 11, 2025
Merged
sap_hana_install: Rework tags #1138
berndfinger
merged 7 commits into
sap-linuxlab:dev
from
berndfinger:issue-1137-rework-tags-for-sap_hana_install
Dec 11, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves issue sap-linuxlab#1137. Also adds tag sap_hana_install_check_hana_exists. Signed-off-by: Bernd Finger <bfinger@redhat.com>
Relates to sap-linuxlab#1137 Signed-off-by: Bernd Finger <bfinger@redhat.com>
Relates to sap-linuxlab#1137. Signed-off-by: Bernd Finger <bfinger@redhat.com>
marcelmamula
requested changes
Dec 8, 2025
The tag sap_hana_install_check_installation has been removed in this commit, for reducing complexity and testing efforts. Relates to sap-linuxlab#1137. Signed-off-by: Bernd Finger <bfinger@redhat.com>
Relates to sap-linuxlab#1137. Signed-off-by: Bernd Finger <bfinger@redhat.com>
Signed-off-by: Bernd Finger <bfinger@redhat.com>
sap_hana_install_hdblcm_commandline, from tasks/main.yml. Signed-off-by: Bernd Finger <bfinger@redhat.com>
marcelmamula
approved these changes
Dec 10, 2025
Contributor
marcelmamula
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ja9fuchs
approved these changes
Dec 11, 2025
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, partially tested the tags. As discussed the check-mode of the role needs fixing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1137. In addition, the tag
sap_hana_install_check_hana_existshas been implemented, for checking if an HANA instance with the desired SID and number is already present.If more than one tag is provided, the role will abort. Allowing more than one tag would have resulted in additional development and testing effort. As the main purpose of these tags is to assist with support and troubleshooting, one tag at a time should be sufficient.