Fairphone 5 Speaker Fixes #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 21, 2025 20:09
For some reason we endedup allocating sdw_stream_runtime for every cpu dai, this has two issues. 1. we never set snd_soc_dai_set_stream for non soundwire dai, which means there is no way that we can free this, resulting in memory leak 2. startup and shutdown callbacks can be called without hw_params callback called. This combination results in memory leak because machine driver sruntime array pointer is only set in hw_params callback. Fix this by 1. adding a helper function to get sdw_runtime for substream which can be used by shutdown callback to get hold of sruntime to free. 2. only allocate sdw_runtime for soundwire dais. Fixes: d32bac9 ("ASoC: qcom: Add helper for allocating Soundwire stream runtime") Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Cc: Stable@vger.kernel.org Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com> Tested-by: Steev Klimaszewski <threeway@gmail.com> # Thinkpad X13s
remove redundant code and pointers to handle sdw_stream_runtime by making use of qcom_snd_sdw_get_stream(). This removes need of machine specific shutdown and hw_params sdw callbacks and also need to store sdw_stream_runtime pointers in machine drivers. Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com> Tested-by: Steev Klimaszewski <threeway@gmail.com> # Thinkpad X13s
sdm845 machine driver can make use of common sdw functions to do most of the soundwire related operations. Remove such redundant code from sdm845 driver. Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com> Tested-by: Steev Klimaszewski <threeway@gmail.com> # Thinkpad X13s
sc7280 machine driver can make use of common sdw functions to do most of the soundwire related operations. Remove such redundant code from sc7280 driver. Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com> Tested-by: Steev Klimaszewski <threeway@gmail.com> # Thinkpad X13s
|
@z3ntu FYI. |
[bharadwaj.raju@machinesoul.in: add sleep pinctrl as well] Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> Signed-off-by: Bharadwaj Raju <bharadwaj.raju@machinesoul.in>
When multiple aw88261 amps are present in a system, they cannot be enabled together since the names of the DAIs, kcontrols, DAPM widgets, and DAPM routes conflict unless they are dynamically renamed to include the channel number as a suffix. Signed-off-by: Bharadwaj Raju <bharadwaj.raju@machinesoul.in>
Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
Add support for the QUINARY_MI2S_RX which is used on some devices to send audio data to speaker amplifiers. Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
... to something that's decently working, at least in some circumstances like with aplay but not paplay still
…e_hw_params_fixup()" This reverts commit 43a3484.
so speaker plays back at correct speed!
Solve the ALSA/ADSP misunderstanding about S24, by advertising S32 to ALSA, while still sending to ADSP as usual (24 bits + padding) This is required because when using, asm_multi_channel_pcm_fmt_blk_v2 expectation from DSP is that we send 24 bits data packed to significant bits packet on 32 bits (pcm_s32le). Signed-off-by: Alexandre Ferrieux <alexandre.ferrieux@orange.com>
bharadwaj-raju
force-pushed
the
sc7280-6.18.y-audio-fixups-clean
branch
from
8cb0ca1 to
05b04e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset fixes speaker output on the Fairphone 5. It consists of: