Skip to content

Merge the tag functionailty into build #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
phracek merged 3 commits into from
Dec 16, 2025
Merged

Merge the tag functionailty into build #413

phracek merged 3 commits into from
Dec 16, 2025

Conversation

@pkhartsk
Copy link
Contributor

@pkhartsk pkhartsk commented Dec 8, 2025 •
edited by github-actions bot
Loading

Merge the tag functionality into build in the Makefiles

@pkhartsk pkhartsk requested a review from phracek December 8, 2025 15:56
@github-actions
Copy link

github-actions bot commented Dec 8, 2025 •
edited
Loading

Pull Request validation

Failed

🔴 Failed or pending statuses:

  • Testing Farm - Fedora - s2i-perl-container[pending]
  • Testing Farm - Fedora - s2i-python-container[pending]
  • Testing Farm - RHEL9 - nginx-container[pending]
  • Testing Farm - Fedora - postgresql-container[pending]

Success

🟢 Review - Reviewed by a member
🟢 Approval - Changes were approved

@pkhartsk
Copy link
Contributor Author

pkhartsk commented Dec 8, 2025

[test-all]

phracek
phracek requested changes Dec 8, 2025
View reviewed changes
Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about to move also tag.sh functionality to build.sh?

We do not need a separate script and functionality.
After build, we can call function tag. Maybe move the tag functionality to common.sh

@github-actions
Copy link

github-actions bot commented Dec 8, 2025 •
edited
Loading

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
Fedora - s2i-base-containerFedora-latestx86_64✅ passed16.12.2025 08:27:3916min 33stest pipeline
Fedora - nginx-containerFedora-latestx86_64✅ passed15.12.2025 13:04:2415min 51stest pipeline
CentOS Stream 10 - s2i-base-containerCentOS-Stream-10x86_64✅ passed15.12.2025 13:38:5112min 29stest pipeline
CentOS Stream 10 - nginx-containerCentOS-Stream-10x86_64✅ passed15.12.2025 13:19:0923min 1stest pipeline
CentOS Stream 9 - nginx-containerCentOS-Stream-9x86_64✅ passed15.12.2025 13:04:2321min 41stest pipeline
CentOS Stream 10 - postgresql-containerCentOS-Stream-10x86_64✅ passed15.12.2025 13:18:5725min 30stest pipeline
Fedora - postgresql-containerFedora-latestx86_64✅ passed16.12.2025 08:27:4223min 12stest pipeline
RHEL10 - postgresql-containerRHEL-10-Nightlyx86_64✅ passed15.12.2025 13:19:3219min 18stest pipeline
RHEL10 - nginx-containerRHEL-10-Nightlyx86_64✅ passed15.12.2025 13:43:3116min 28stest pipeline
RHEL10 - s2i-perl-containerRHEL-10-Nightlyx86_64✅ passed15.12.2025 13:53:1428min 29stest pipeline
CentOS Stream 10 - s2i-perl-containerCentOS-Stream-10x86_64✅ passed15.12.2025 13:12:0234min 52stest pipeline
RHEL8 - nginx-containerRHEL-8.10.0-Nightlyx86_64✅ passed15.12.2025 13:00:0621min 14stest pipeline
RHEL8 - s2i-perl-containerRHEL-8.10.0-Nightlyx86_64✅ passed15.12.2025 13:39:5029min 24stest pipeline
RHEL9 - nginx-containerRHEL-9.6.0-Nightlyx86_64✅ passed16.12.2025 08:27:4129min 28stest pipeline
RHEL9 - s2i-perl-containerRHEL-9.6.0-Nightlyx86_64✅ passed15.12.2025 13:48:2739min 20stest pipeline
RHEL10 - s2i-base-containerRHEL-10-Nightlyx86_64✅ passed15.12.2025 13:37:1518min 37stest pipeline
RHEL9 - postgresql-containerRHEL-9.6.0-Nightlyx86_64✅ passed15.12.2025 13:00:3536min 30stest pipeline
CentOS Stream 9 - s2i-base-containerCentOS-Stream-9x86_64✅ passed15.12.2025 13:23:3423min 58stest pipeline
Fedora - s2i-python-containerFedora-latestx86_64✅ passed16.12.2025 08:27:4040min 36stest pipeline
RHEL8 - s2i-base-containerRHEL-8.10.0-Nightlyx86_64✅ passed15.12.2025 13:54:3119min 4stest pipeline
Fedora - s2i-perl-containerFedora-latestx86_64✅ passed16.12.2025 08:27:3944min 2stest pipeline
RHEL8 - postgresql-containerRHEL-8.10.0-Nightlyx86_64✅ passed15.12.2025 13:45:1840min 52stest pipeline
RHEL10 - s2i-python-containerRHEL-10-Nightlyx86_64✅ passed15.12.2025 13:32:3228min 11stest pipeline
CentOS Stream 9 - postgresql-containerCentOS-Stream-9x86_64✅ passed15.12.2025 13:18:0834min 11stest pipeline
RHEL9 - s2i-base-containerRHEL-9.6.0-Nightlyx86_64✅ passed15.12.2025 13:54:3323min 2stest pipeline
CentOS Stream 10 - s2i-python-containerCentOS-Stream-10x86_64✅ passed15.12.2025 13:45:2458min 11stest pipeline
RHEL9 - s2i-python-containerRHEL-9.6.0-Nightlyx86_64✅ passed15.12.2025 13:30:151h 22min 23stest pipeline
CentOS Stream 9 - s2i-python-containerCentOS-Stream-9x86_64✅ passed15.12.2025 13:50:321h 26min 9stest pipeline
RHEL8 - s2i-python-containerRHEL-8.10.0-Nightlyx86_64✅ passed15.12.2025 13:22:402h 2min 59stest pipeline
CentOS Stream 9 - s2i-perl-containerCentOS-Stream-9x86_64✅ passed15.12.2025 13:20:2031min 32stest pipeline

@phracek
Copy link
Member

phracek commented Dec 10, 2025

For RHEL10 tests there is an issue:

-> Pulling image ubi9/s2i-core before building image from Dockerfile.rhel10.
Resolved "ubi9/s2i-core" as an alias (/etc/containers/registries.conf.d/001-rhel-shortnames.conf)
Trying to pull registry.access.redhat.com/ubi9/s2i-core:latest...

Pulling ubi9/s2i-core for Dockerfile.rhel10 does not make sense.

@pkhartsk
Copy link
Contributor Author

pkhartsk commented Dec 15, 2025

For RHEL10 tests there is an issue:

-> Pulling image ubi9/s2i-core before building image from Dockerfile.rhel10.
Resolved "ubi9/s2i-core" as an alias (/etc/containers/registries.conf.d/001-rhel-shortnames.conf)
Trying to pull registry.access.redhat.com/ubi9/s2i-core:latest...

Pulling ubi9/s2i-core for Dockerfile.rhel10 does not make sense.

@phracek This isn't my error, as it was already pulling ubi9 before, e.g. here. The issue here was just that it couldn't pull it. Not sure how to fix it, though.

@phracek
Copy link
Member

phracek commented Dec 15, 2025

[test]

phracek
phracek approved these changes Dec 15, 2025
View reviewed changes
Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. Let's wait for the rest of tests

@pkhartsk pkhartsk mentioned this pull request Dec 16, 2025
Merged
@phracek phracek merged commit 887c3a7 into master Dec 16, 2025
34 checks passed
@phracek phracek deleted the merge-build-tag branch December 16, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phracek phracek phracek approved these changes

Assignees

No one assigned

Labels

pr/failing-ci pr/needs-manual-merge ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pkhartsk @phracek