Skip to content

Conversation

@seanf
Copy link
Owner

@seanf seanf commented Mar 9, 2018

No description provided.

@seanf seanf requested a review from efloden March 9, 2018 07:58
@zubot
Copy link

zubot commented Mar 9, 2018

This change is Reviewable

@codecov
Copy link

codecov bot commented Mar 9, 2018

Codecov Report

Merging #11 into master will decrease coverage by 2.64%.
The diff coverage is 28.12%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #11      +/-   ##
============================================
- Coverage     37.33%   34.68%   -2.65%     
+ Complexity       30       22       -8     
============================================
  Files             3        3              
  Lines           375      418      +43     
  Branches         43       72      +29     
============================================
+ Hits            140      145       +5     
- Misses          215      253      +38     
  Partials         20       20
Impacted Files Coverage Δ Complexity Δ
...ava/org/zanata/proxyhook/server/ProxyHookServer.kt 9.5% <15.32%> (-0.5%) 1 <1> (-6)
...ava/org/zanata/proxyhook/client/ProxyHookClient.kt 61.76% <51.47%> (-2.64%) 21 <9> (-2)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 632b1cb...8fa886a. Read the comment docs.

Repository owner deleted a comment Mar 9, 2018
Repository owner deleted a comment Mar 9, 2018
Repository owner deleted a comment Mar 9, 2018
Repository owner deleted a comment Mar 9, 2018
Repository owner deleted a comment Mar 9, 2018
Repository owner deleted a comment Mar 9, 2018
Repository owner deleted a comment Mar 9, 2018
Repository owner deleted a comment Mar 9, 2018
Repository owner deleted a comment Mar 9, 2018
Repository owner deleted a comment Mar 9, 2018
Repository owner deleted a comment Mar 9, 2018
Repository owner deleted a comment Mar 9, 2018
Repository owner deleted a comment Mar 9, 2018
Repository owner deleted a comment Mar 9, 2018
@efloden
Copy link

efloden commented Mar 13, 2018

Reviewed 9 of 15 files at r1, 2 of 2 files at r2, 4 of 4 files at r3.
Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.


gradlew, line 157 at r3 (raw file):

fi

# Escape application args

Could show an example of the expected before/after args in the comment here?


Comments from Reviewable

@seanf
Copy link
Owner Author

seanf commented Mar 13, 2018

Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.


gradlew, line 157 at r3 (raw file):

Previously, efloden (Earl Floden) wrote…

Could show an example of the expected before/after args in the comment here?

This script is provided by Gradle Wrapper, so we just copy it in to the source tree as is.

https://docs.gradle.org/current/userguide/gradle_wrapper.html


Comments from Reviewable

@efloden
Copy link

efloden commented Mar 13, 2018

:lgtm:


Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


Comments from Reviewable

Repository owner deleted a comment Sep 14, 2018
Repository owner deleted a comment Sep 14, 2018
Repository owner deleted a comment Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants