Adding iPhone XS, XR and XS Max #90
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…moved compiler warnings on version. Updated to Swift 4.2
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for the new three devices from iOS, iPhone XS, iPhone XR and iPhone XS Max.
This request also adds better device type differentiation by using the screen pixel values instead of the points value. This can matter when dealing with resolution issues. For instance, the iPhone XR and iPhone XS Max have the same point size, but the resolution is doubled in the Max (@2x vs @3x)
Device names are best as known now, until the new devices are release we don't know all the possible ones that will make themselves known, but I will update the pull request, or create a new one, when that happens.
I have also fixed a few compiler errors dealing with deprecated functions in the test iOS project.