#3612 "Copy SLURL" from Favorites bar not working #2 #5116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxim-productengine
approved these changes
Dec 8, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #3612 by improving the user experience when trying to copy SLURL or show landmarks on the map for regions that are unavailable or have been removed. Instead of silently disabling the menu options, the code now displays a warning notification to inform users about the issue.
Key Changes:
- Added a new notification message "LandmarkLocationUnknown" to inform users when a landmark's region location cannot be retrieved
- Modified the
enableSelectedmethod to check for landmark asset existence rather than valid position, allowing the menu items to remain enabled - Updated the
doToSelectedmethod to display the notification when position retrieval fails for both "copy_slurl" and "show_on_map" actions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| indra/newview/skins/default/xui/en/notifications.xml | Adds new notification message for when landmark location is unavailable |
| indra/newview/llfavoritesbar.cpp | Updates menu enable logic and adds notification display when landmark position cannot be retrieved |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
marchcat
approved these changes
Dec 8, 2025
akleshchev
force-pushed
the
andreyk/viewer_3612
branch
from
541f7b4 to
99c4125
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided that simply disabling menu isn't a nice mehanics, warning user about region being down/removed instead.