fix: Allow image tag to contain digest #27
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes kubernetes label not being allowed to contain digest by replacing invalid characters in tag and truncating to 63 chars.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows for the image tag to contain the digest. Currently this is not possible as the tag is added as label and labels may not contain ':' or '@' nor exceed 63 characters. This PR fixes this by replacing invalid characters and truncating beyond 63 characters of the tag for the label. This fix shouldn't change the behavior of the label for tags without digest.
The label created after the fix for tag
latest@sha256:8d7a1bf44226f2fbcb232edded836ca83a5c13c694575067f11322e19e2a7a0fisapp.kubernetes.io/version: latest_sha256_8d7a1bf44226f2fbcb232edded836ca83a5c13c694575067f.