Skip to content

Conversation

@nfischer
Copy link
Member

@nfischer nfischer commented May 9, 2025

This removes the babel transpiler and refactors the code to be compatible with commonjs imports.

Test: npm test
Test: echo "foo\nfoobar\nbar" | ./src/cli.js grep 'foo'
Test: echo "foo\nfoobar\nbar" | ./src/cli.js sed 's/foo/bar/'
Test: ./src/cli.js grep 'foo' ~/foobartest.txt
Test: ./src/cli.js sed 's/foo/bar/' ~/foobartest.txt

@codecov
Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bd48247) to head (b3809f9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #237   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          122       126    +4     
=========================================
+ Hits           122       126    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nfischer nfischer force-pushed the refactor-no-babel branch from 690c448 to adf3c67 Compare May 11, 2025 19:47
This removes the babel transpiler and refactors the code to be
compatible with commonjs imports.

Test: npm test
Test: echo "foo\nfoobar\nbar" | ./src/cli.js grep 'foo'
Test: echo "foo\nfoobar\nbar" | ./src/cli.js sed 's/foo/bar/'
Test: ./src/cli.js grep 'foo' ~/foobartest.txt
Test: ./src/cli.js sed 's/foo/bar/' ~/foobartest.txt
@nfischer nfischer force-pushed the refactor-no-babel branch from adf3c67 to b3809f9 Compare May 11, 2025 19:57
@nfischer nfischer merged commit 17c363c into main May 11, 2025
20 checks passed
@nfischer nfischer deleted the refactor-no-babel branch May 11, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants