Skip to content

feat: add caching policies documentation #2029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
keulinho merged 11 commits into from
Dec 17, 2025
Merged

feat: add caching policies documentation #2029

keulinho merged 11 commits into from
Dec 17, 2025

Conversation

@h1k3r
Copy link
Contributor

@h1k3r h1k3r commented Dec 8, 2025 •
edited
Loading

@h1k3r h1k3r self-assigned this Dec 8, 2025
@h1k3r
Copy link
Contributor Author

h1k3r commented Dec 8, 2025 •
edited
Loading

I am thinking if it makes sense to add workflow description (and where) 🤔
It should describe smth like this:

  • user request
  • applying lang/currency/vary headers
  • deciding if request is cacheable
  • applying cache hash
  • resolving a policy
  • applying policy (mention merge rules)
  • response

@keulinho wdyt?

keulinho
keulinho reviewed Dec 9, 2025
View reviewed changes
@Isengo1989 Isengo1989 added this to the 6.7.6.0 milestone Dec 9, 2025
@Isengo1989 Isengo1989 added the Undocumented Feature Feature which is not documented yet and is considered for documentation label Dec 9, 2025
@h1k3r h1k3r requested a review from keulinho December 11, 2025 21:48
keulinho
keulinho reviewed Dec 16, 2025
View reviewed changes
Isengo1989
Isengo1989 approved these changes Dec 16, 2025
View reviewed changes
Copy link
Contributor

@Isengo1989 Isengo1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the PR @h1k3r 👍

LGTM from ours end

@keulinho keulinho merged commit f3d662d into main Dec 17, 2025
9 checks passed
@keulinho keulinho deleted the feat-add-caching-policies-docs branch December 17, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keulinho keulinho keulinho approved these changes

@Isengo1989 Isengo1989 Isengo1989 approved these changes

@BrocksiNet BrocksiNet Awaiting requested review from BrocksiNet

@shyim shyim Awaiting requested review from shyim

@nfortier-shopware nfortier-shopware Awaiting requested review from nfortier-shopware

Assignees

@h1k3r h1k3r

Labels

Undocumented Feature Feature which is not documented yet and is considered for documentation

Projects

None yet

Milestone

6.7.6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@h1k3r @Isengo1989 @keulinho