Skip to content

Conversation

@RaymondLuong3
Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 commented Jan 2, 2026

This PR fixes the close button on the supported back translation languages dialog which was not working because the component needed to import the directive.

image

This change is Reviewable

@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.82%. Comparing base (0796248) to head (d253a20).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3619   +/-   ##
=======================================
  Coverage   82.82%   82.82%           
=======================================
  Files         610      610           
  Lines       37414    37414           
  Branches     6147     6128   -19     
=======================================
  Hits        30987    30987           
- Misses       5481     5494   +13     
+ Partials      946      933   -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmachapman pmachapman force-pushed the fix/supported-back-translation branch from d35ffa8 to d253a20 Compare January 4, 2026 18:50
@pmachapman pmachapman self-assigned this Jan 4, 2026
@pmachapman pmachapman self-requested a review January 4, 2026 18:54
Copy link
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Thank you for fixing this. I did a quick search and couldn't see any other dialogs that might be affected by this bug.

@pmachapman reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RaymondLuong3).

@pmachapman pmachapman enabled auto-merge (squash) January 4, 2026 18:57
@pmachapman pmachapman merged commit dd2b2cb into master Jan 4, 2026
21 checks passed
@pmachapman pmachapman deleted the fix/supported-back-translation branch January 4, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants