Deduplication of toolcalls #146
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did this once, then we reverted it because we weren't doing subs restart on purpose, but we can still have subscription restart without restart of all other things (there is even a bc.thread_tracker.clear() with a comment about it), and it was happening somehow in scenarios some times
There are other less likely to happen cases that could also send a toolcall more than once, like a toolcall appearing at the same time than the subscription, so it could be fetched from database, then the news from the database being processed and send to redis, then subs sends it again in redis, which could cause tool call to be sent twice, so it is probably better to deduplicate in bot still