Improve error message #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thevart
reviewed
Nov 6, 2017
| const CONF_RECOVERABLE = 'recoverable'; | ||
|
|
||
| const CONF_NO_RESULTS = 'noResults'; | ||
| const CONF_NO_RESULTS = 'no_results'; |
Contributor
There was a problem hiding this comment.
Hi @BertrandF23 ,
This is potentially a breaking change on the framework for other user of the bundle.
I would recommend not to do it as part of this pull request.
Contributor
Author
There was a problem hiding this comment.
Ok, was split and put in another pull request :-).
| */ | ||
| public function keyExists(array $obj, $key) | ||
| { | ||
| if (!is_string($key) and !is_integer($key)) { |
Contributor
There was a problem hiding this comment.
@BertrandF23 we should add/update the tests for this change
Contributor
Author
There was a problem hiding this comment.
Tests are done for keyExists, testing true or false result, but also exceptions due to wrong type of parameters.
BertrandF23
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.