test: use preview CLI when stable is not released #683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a safeguard to ensure the toggle has been switched back to testing the stable CLI for the protocol version when the release pipeline runs. Add a new test that ensures the stable CLI isn't available if the flag is set to say it isn't. Made PR tests run on all PRs, not just those into main. Run the PR CI pipelines of the branch, not rely on main's.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
rrama
commented
Nov 19, 2025
| on: | ||
| workflow_dispatch: | ||
| branches: | ||
| - main |
Contributor
Author
There was a problem hiding this comment.
FYI, I removed this because you cannot set branches on workflow_dispatch.
…table-cli-until-release
Contributor
Author
|
CI tests are failing on this branch because we require this fix to the configuration tests first: #691 |
The ConfigurationWatcher checks `isLSUpdatingOrg(folderPath)` when processing config changes. If a folder path exists in the static `foldersBeingUpdatedByLS` `Set`, then the watcher skips syncing that folder's configuration.
rrama
force-pushed
the
test/allow-skipping-stable-cli-until-release
branch
from
99e8022 to
12533c3
Compare
rrama
force-pushed
the
test/allow-skipping-stable-cli-until-release
branch
from
12533c3 to
71be1b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With a safeguard to ensure the toggle has been switched back to testing the stable CLI for the protocol version when the release pipeline runs.
Add a new test that ensures the stable CLI isn't available if the flag is set to say it isn't.
Made PR tests run on all PRs, not just those into main.
Run the PR CI pipelines of the branch, not rely on main's.
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!