Skip to content

Conversation

@RichDom2185
Copy link
Member

@RichDom2185 RichDom2185 commented Aug 18, 2023

Adds some relatively-straightforward tests in some places.

@RichDom2185 RichDom2185 self-assigned this Aug 18, 2023
@RichDom2185
Copy link
Member Author

@YaleChen299 should AnyOf pass or fail in the trivial case with 0 permissions?

@RichDom2185
Copy link
Member Author

My opinion is:

  • "All of N" → "pass if you fulfil all N requirements" → all of nothing means all requirements out of 0 will always be fulfilled → always pass
  • "Any of N" → "pass if you have at least one out of N" → you can't have at least one permission out of 0 (because there are no permissions in the first place for you to have) → always fail

But this is up for discussion, depending on what makes sense for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants