Replacing mcrypt with openssl for compatibility reasons #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi @splittingred, it's been over a year and the PR hasn't been approved yet. No big deal for me, I opened up this PR for a client of mine back in the day. But apparently some people are using my code and @Mark-H needed some improvements to be done. It would make a lot more sense to do these improvements upstream, but this PR needs to be approved first before this can happen. The last PHP version that supported the current implementation, was retired last year. I guess it would make sense to use Thanks for considering. |
matdave
added a commit
to modxcms/FileLister
that referenced
this pull request
Apr 16, 2024
version bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of PHP 7.2, mcrypt is no longer available, which causes incompatibility for this module.
This pull requests replaces the mcrypt functions with openssl functions without loss of functionality.