Fixes bug with debug=1 system setting #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you have debug=1 in system settings, manager pages with quip components are broken. This is due to the lines 128-131, which change the set error behaviour of your system (NEVER put out errors to HTML...). The revealing error was the access to config['debugUser'], which may not be set. This throws the error ``` Notice: Undefined index: debugUser in /core/components/quip/model/quip/quip.class.php on line 132 ``` This error was already reported at http://bugs.modx.com/issues/8467 and on other places, but was never corrected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have debug=1 in system settings, manager pages with quip components are broken. This is due to the lines 128-131, which change the set error behaviour of your system (NEVER put out errors to HTML...).
The revealing error was the access to config['debugUser'], which may not be set. This throws the error
This error was already reported at http://bugs.modx.com/issues/8467 and on other places, but was never corrected.