Implemented most of the BrowserWindow api accessors. Extended the wrappe... #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
also added common.noop. Its an optimization. Allows the v8 optimizing compiler to use 1 function and optimize it, rather than generating a new function on every call. |
…pper dnode to allow for passing results back through callbacks, as well as events
Contributor
|
hey @spolu can you review this pr? :) |
Owner
|
@jden work on this repository is deprecated and has moved to this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...r dnode to allow for passing results back through callbacks, as well as events
Accept it if you like it, just felt this was a nice way to help out for now.
I return "this" from each funtion since you were starting to do method chaining and assignment but it actually didnt work because no this was returned.
There is an options.strictApi for throwing errors on function that return a value, throw error if now callback.
Pretty simple just alot of typing heh.