Skip to content

Allow OllamaApiAutoConfiguration conditional instantiation based on chat model and embedding model properties #5077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nicolaskrier wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow OllamaApiAutoConfiguration conditional instantiation based on chat model and embedding model properties #5077

nicolaskrier wants to merge 1 commit into from
+76 −2

Conversation

@nicolaskrier
Copy link
Contributor

@nicolaskrier nicolaskrier commented Dec 10, 2025

  • Introduce OllamaChatOrEmbeddingCondition for this logic
  • Add unit tests covering the different scenarios

@nicolaskrier
Allow OllamaApiAutoConfiguration conditional instantiation based on c…
b2d53e9 
…hat model and embedding model properties

- Introduce OllamaChatOrEmbeddingCondition for this logic
- Add unit tests covering the different scenarios

Signed-off-by: Nicolas Krier <7557886+nicolaskrier@users.noreply.github.com>
@nicolaskrier
Copy link
Contributor Author

nicolaskrier commented Dec 12, 2025 •
edited
Loading

In 1.1.0-M2 version, OllamaApiAutoConfiguration was:

These two former auto-configurations have conditions on different properties to disable them. I have reintroduced these conditions on OllamaApiAutoConfiguration directly because it is now present in Ollama auto-configuration imports file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nicolaskrier