Allow specifying other handover methods when establishing session #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cobward
approved these changes
Mar 26, 2025
Contributor
|
Thanks for the contribution! Sorry we didn't see this until now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! First off, thank you for making this library, it's been working great for me.
I have one small improvement suggestion, the current
reader::SessionManager::establish_sessionfunction only works with QR code engagements. It seems pretty straightforward to update it to accept any type of engagement. I've tested this approach for NFC handover and it seems to work as expected.Please feel free to let me know if there's a better way to do this!