[WIP DNR] Alex/label deferral #598
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyalPineapple
force-pushed
the
alex/migrateA11y
branch
from
3511a17 to
9d4dd5b
Compare
RoyalPineapple
force-pushed
the
alex/labelDeferral
branch
from
fe80b79 to
3eb1400
Compare
RoyalPineapple
force-pushed
the
alex/labelDeferral
branch
from
1fb1fd4 to
0dab374
Compare
RoyalPineapple
force-pushed
the
alex/labelDeferral
branch
from
447d79f to
8f82857
Compare
RoyalPineapple
force-pushed
the
alex/labelDeferral
branch
from
80b442d to
025d5b2
Compare
RoyalPineapple
commented
Dec 16, 2025
| new.rotors = rotors + merge.rotors | ||
| new.interactiveChildren = interactiveChildren + merge.interactiveChildren | ||
|
|
||
| // TODO: ADD FRAME SUPPORT? lets not change the activation point as we didn't change the activation item |
Collaborator
Author
There was a problem hiding this comment.
- remove todo, its done
RoyalPineapple
commented
Dec 16, 2025
| // An accessibility representation with values that should override the combined representation | ||
| public var overrideValues: AccessibilityComposition.CompositeRepresentation? = nil | ||
|
|
||
| // An accessibility representation with values that should be merged with combined representation |
Collaborator
Author
There was a problem hiding this comment.
nit: "merged with the combined..."
RoyalPineapple
commented
Dec 16, 2025
| let combined = combineChildren(filter: customFilter, sorting: sorting) | ||
| let accessibility = combineChildren(filter: customFilter, sorting: sorting) | ||
| .override(with: overrideValues) | ||
| .merge(with: mergeValues) |
Collaborator
Author
There was a problem hiding this comment.
should we consider overwriting if both exist?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Creates
AccessibilityDeferral.RecieverContainerallowing arbitrary elements to receive delegated accessibility without themselves needing to conform to theAccessibilityDeferral.Receiverprotocol.