feat: add env-value-from as opt-in check for #705 #1032
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1032 +/- ##
===========================================
- Coverage 62.36% 28.16% -34.20%
===========================================
Files 197 235 +38
Lines 4854 6295 +1441
===========================================
- Hits 3027 1773 -1254
- Misses 1439 4362 +2923
+ Partials 388 160 -228
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Nexusrex18
force-pushed
the
env-value-from-feature
branch
2 times, most recently
from
8a2e5bf to
34abcca
Compare
Nexusrex18
force-pushed
the
env-value-from-feature
branch
from
68ddc2e to
4c224e9
Compare
| func Keys[K comparable, V any](m map[K]V) []K { | ||
| r := make([]K, 0, len(m)) | ||
| for k := range m { | ||
| r = append(r, k) | ||
| } | ||
| return r | ||
| } |
There was a problem hiding this comment.
| func lintForEachContainer(lintCtx lintcontext.LintContext, object lintcontext.Object, ignoredSecrets, ignoredConfigMaps []*regexp.Regexp, secrets map[string]*v1.Secret, configmaps map[string]*v1.ConfigMap) []diagnostic.Diagnostic { | ||
| return util.PerContainerCheck(func(container *v1.Container) []diagnostic.Diagnostic { | ||
| var results []diagnostic.Diagnostic | ||
| for _, envVar := range container.Env { |
There was a problem hiding this comment.
Loop body looks like copied. How about having a type that will have common parts from secrets and config maps and additional type name [secret, config map] (that could be used in errors) so we can have simple code?
janisz
left a comment
janisz
left a comment
There was a problem hiding this comment.
Looks good, the only problem is duplicated code
2 participants
Implements env-value-from check from #705 as opt-in (via config.yaml 'include'). If maintainers prefer, can add to default checks in a follow-up.