support wasm #26
Open
support wasm #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could this PR be prioritized? I'm also finding myself blocked in building a wasm target using this crate as a dependency. |
Member
|
I don't have time to review this PR at the moment. In the meantime you can include mail-builder from the contributor's repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently wasm targets are not supported, as
std::time::SystemTime::now()panics on wasm targets. This change adds support for wasm via thewasmtimercrate crate for getting the current timestamp.Note that also
gethostnameneeds to be disabled for wasm.Why
wasmtimerinstead ofweb-time?wasmtimeralso has support for functionality fromtokio::timeliketimeout, which will come in handy when for examplemail-sendwill support wasm and then both packages can share the same dependency.