Synchronize with IGLU-R v4.3.0 and improve compatibility #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…other libraries ( such as databricks)
- Change MAG function parameter 'n' from int=60 to int|None=None to match new IGLU-R behavior - Update test expectations to reflect IGLU-R v4.3.0 calculation results - Bump version to 0.3.0 to reflect compatibility with IGLU-R v4.3.0 - Add MAG evaluation notebook for testing and validation This update ensures compatibility with the latest IGLU-R development version (4.3.0) installed from GitHub, addressing changes in the MAG calculation algorithm.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
==========================================
+ Coverage 90.81% 91.16% +0.34%
==========================================
Files 46 46
Lines 1764 1754 -10
==========================================
- Hits 1602 1599 -3
+ Misses 162 155 -7 ☔ View full report in Codecov by Sentry. |
staskh
deleted the
9-synchronise-with-2025-07-12-iglu-r-implementation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR synchronizes the IGLU-Python implementation with the latest IGLU-R v4.3.0 and includes several improvements for better compatibility and usability.
Changes Summary
🔄 IGLU-R Synchronization
nfromint=60toint|None=Noneto match new IGLU-R behavior🛠️ Dependency Improvements
📊 Testing & Validation
mag_evaluation.ipynbfor comprehensive MAG function testingFiles Changed
iglu_python/mag.py- Updated MAG function implementationpyproject.toml- Version bump and dependency relaxationtests/test_mag.py- Updated test expectationstests/expected_results.json- Updated reference datanotebooks/mag_evaluation.ipynb- New evaluation notebookREADME.md- Updated compatibility informationTesting
Impact
This update ensures IGLU-Python remains fully compatible with the latest IGLU-R development version while improving overall package usability and dependency management.
Related to: #9 - Synchronise with 2025-07-12 IGLU-R implementation