Fix plot_daily for missing dates and add timezone/DST tests #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix bug in plot_daily: handle timeseries with missing dates correctly
- Changed from resample('D') to groupby(normalize()) to only include days with data
- Prevents KeyError when trying to get groups for days without data
- Add comprehensive unittests for plot_daily:
- Test missing dates (non-continuous timeseries)
- Test multiple missing dates
- Test single day in middle of range
- Test timezone-aware (non-UTC) timeseries
- Test DST spring forward (losing an hour)
- Test DST fall back (gaining an hour)
- Bump version to 0.4.3
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on December 6. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
==========================================
+ Coverage 90.37% 90.38% +0.01%
==========================================
Files 46 46
Lines 1797 1799 +2
==========================================
+ Hits 1624 1626 +2
Misses 173 173 ☔ View full report in Codecov by Sentry. |
staskh
deleted the
17-bug-exception-in-plot_daily-for-not-continuous-timeseries
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug in
plot_dailythat caused a KeyError when processing timeseries with missing dates, and adds comprehensive unittests for timezone-aware data and DST transitions.Changes
Bug Fix
plot_dailyto handle timeseries with missing dates correctlyresample('D')togroupby(normalize())to only include days with dataTests Added
Version
Testing
All existing tests pass, and new tests verify the functionality works correctly with: