Propagate Shopify translations to entry localizations #313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into a few snags syncing translated products and variants into a multisite setup.
Following the docs, we set the collections to propagate, but localizations are currently only created if the product or variant is actually translated in Shopify. This will lead to unpublished products in non-default locales on the Statamic side of things. Which differs from the default behavior of a Shopify theme, which would show the untranslated product and fall back to the default locale for display. Checking for the propagate flag of the collection and always creating those entries seems to work here.
When compiling variants data, translated entries currently don't have any price or inventory data, leading to exceptions when calculating in-stock status and displaying prices. Switching from
data()tovalues()and filtering down to unique variant ids seems to work here.