Skip to content

Fix already connected pheriperal after restoration #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gKamelo wants to merge 2 commits into
base: master
Choose a base branch
from
+12 −2
Open

Fix already connected pheriperal after restoration #235

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3832b30
Fix already connected pheriperal after restoration
gKamelo Apr 26, 2020
fc88b77
Skip observers notifying about already connected pheriperal
gKamelo Jun 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions Bluejay/Bluejay/Bluejay.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1305,15 +1305,25 @@ extension Bluejay: CBCentralManagerDelegate {

connectingCallback = nil

connectedPeripheral = connectingPeripheral
let wasConnected = isConnected

debugLog("Central manager connected to perihperal already: \(wasConnected)")

connectedPeripheral = connectingPeripheral ?? connectedPeripheral
connectingPeripheral = nil

precondition(connectedPeripheral != nil, "Connected peripheral is assigned a nil value despite Bluejay has successfully finished a connection.")

shouldAutoReconnect = true
debugLog("Should auto-reconnect: \(shouldAutoReconnect)")

queue.process(event: .didConnectPeripheral(connectedPeripheral!), error: nil)
if queue.first is Connection {
queue.process(event: .didConnectPeripheral(connectedPeripheral!), error: nil)
}

guard !wasConnected else {
return
}

for observer in connectionObservers {
observer.weakReference?.connected(to: connectedPeripheral!.identifier)
Expand Down