Prevents enqueueing assets when an empty array is provided #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a check in the `enqueue` method to prevent any asset enqueueing when an empty array is explicitly passed. This ensures the method behaves as expected in such scenarios. Also adds a test to verify that no assets are enqueued when a non-existent group is requested via `enqueue_group`.
Camwyn
reviewed
Aug 26, 2025
| * @since 1.4.11 - If explicitly passed an empty array, enqueue nothing. | ||
| */ | ||
| public function enqueue( $assets_to_enqueue = null, bool $should_enqueue_no_matter_what = false ) { | ||
| // If explicitly passed an empty array, enqueue nothing. |
Contributor
There was a problem hiding this comment.
So the expected behavior is if $assets_to_enqueue is empty (null - not an array) we should enqueue everything?
Member
Author
There was a problem hiding this comment.
Yes that keeps the library backwards compatible
Camwyn
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a check in the
enqueuemethod to prevent any asset enqueueingwhen an empty array is explicitly passed. This ensures the method
behaves as expected in such scenarios.
Also adds a test to verify that no assets are enqueued when a
non-existent group is requested via
enqueue_group.