fix(a2a): use a2a artifact update event #1401
Open
+61
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brycewcole
requested a deployment
to
manual-approval
GitHub Actions
Waiting
brycewcole
force-pushed
the
a2a-artifact-update
branch
from
4fca63b to
4b5ba77
Compare
brycewcole
requested a deployment
to
manual-approval
GitHub Actions
Waiting
fix: update tests fix: simplify code by storing in class fix: remove uneeded code change
brycewcole
force-pushed
the
a2a-artifact-update
branch
from
4b5ba77 to
39aab40
Compare
brycewcole
requested a deployment
to
manual-approval
GitHub Actions
Waiting
brycewcole
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the a2a executor to use the a2a libraries artifact append function. Intermediate chunks are best represented by artifact updates with append set to true, not task status updates. Please see this discussion on the a2a repo for more justification.
Related Issues
#1377
Documentation PR
N/A
Type of Change
Bug fix
Testing
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.