Fix code block copy button #1385
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-dmatthews
requested review from
sfc-gh-kmcgrady and
sfc-gh-tteixeira
as code owners
sfc-gh-dmatthews
requested review from
a team
and removed request for
sfc-gh-kmcgrady
Contributor
|
Just noticed an unintended side effect on code blocks on the API reference page After
Before
|
Contributor
Author
|
Thanks @snehankekre! This was a little fiddly, but I think I have a fix. However, it's a little cleaner to change all the code blocks with the theme instead of just RefCards, but if it's design-vetoed, I can move the color changes into more special-casing in the RefCard CSS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
The copy button is missing from codeblocks (except those that are inside of docstrings). This PR fixes that and adds a parameter to optionally hide the copy button, such as for blocks used to show file structures.
🧠 Description of Changes
After
Before
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.