feat(filters): support GrokFilter target and string array input #740
+215
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GrokFilter is really useful to parse unstructured data. When I tried to use it with a *BytesArrayInputReader I missed 2 things:
To solve this, I added support of the
targetfield:From:
{ "message": "1970-01-01 00:00:00,000 INFO a dummy log message", "timestamp": "1970-01-01 00:00:00,000", "level": "INFO" }To:
{ "message": "1970-01-01 00:00:00,000 INFO a dummy log message", "parsed": { "message": "a dummy log message", "timestamp": "1970-01-01 00:00:00,000", "level": "INFO" } }To solve this, I added support of array string input as well as the existing string input.
Note: The following example is not really relevant as we would generally read a log file line by line (it shows the objective)
From:
{ "message": ["1970-01-01 00:00:00,000 INFO a dummy log message", "1970-01-01 01:00:00,000 INFO a second dummy log message", "1970-01-01 02:00:00,000 INFO a third dummy log message"] }To:
{ "parsed": [{ "message": "a dummy log message", "timestamp": "1970-01-01 00:00:00,000", "level": "INFO" }, { "message": "a second dummy log message", "timestamp": "1970-01-01 01:00:00,000", "level": "INFO" }, { "message": "a third dummy log message", "timestamp": "1970-01-01 00:00:00,000", "level": "INFO" }] }This PR enhances the GrokFilter while keeping the original behaviour. Look forward to having your feedback !