Add python3 compatability for gen_tzinfo.py and gen_tests.py #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cphang99
force-pushed
the
cphang/py3-gen_tzinfo
branch
from
b588490 to
86e04ee
Compare
stub42
reviewed
Jan 7, 2019
Owner
stub42
left a comment
stub42
left a comment
There was a problem hiding this comment.
Looks fine, but overkill. There is no reason to ensure that the gen_*.py scripts keep running under Python2. The .travis.yml can remain the same, and PYTHON=/usr/bin/python3 set in the Makefile. This also makes the __future__ imports unnecessary.
added 5 commits
November 3, 2019 22:20
gen_tzinfo.py contains some python2 specific code, that is made compatible with python3 as well. In link() io.open is utilised so that the method of dealing with decoding errors with binary data in tz/ is explicitly handled (and can be used in python2 and 3).
cphang99
force-pushed
the
cphang/py3-gen_tzinfo
branch
from
86e04ee to
dfbcc63
Compare
Author
|
@stub42 apologies for the v.long delay in getting updates to you. I've updated the branch to have only python3 compatability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds python3 compatibility for gen_tzinfo.py and gen_tests.py, whilst maintaining existing python2 support.
Some distributions (fedora) are planning to default
/usr/bin/pythonto python3. Other base runtimes (freedesktop-sdk) plan to deprecate python2 completely, meaning that building pytz against this runtime will not be possible.We add an additional command to the travis script, and enabling the
PYTHONmake variable to be user-configurable, to allow CI to test for python3 build compatibility.