Skip to content

Conversation

@v-hemish
Copy link

No description provided.

@super30admin
Copy link
Owner

  • Strengths:
    • Both solutions are correct and efficiently implemented.
    • The code is clean, readable, and follows best practices.
    • Appropriate data structures (deque) are used for BFS and topological sort.
  • Areas for Improvement:
    • In problem1.py, the comment "# Space Complexity: O(N)" and "# Time Complexity: O(N)" could be more specific, mentioning that N is the number of nodes in the tree.
    • In problem2.py, the comment could similarly specify that N is the number of courses or nodes in the graph.
    • While not necessary, adding a brief docstring explaining the function's purpose could enhance readability further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants