Skip to content

Conversation

@ChevvaBhargavi1809
Copy link

No description provided.

@super30admin
Copy link
Owner

  • Strengths:

    • The MinHeap implementation in Problem1.java is excellent. It correctly handles insertions, deletions, and heapify operations with proper time complexity.
    • The binary search approach in Problem2.java is on the right track and shows understanding of the problem.
  • Areas for Improvement:

    • In Problem2.java, the return statement should return arr[low] + 1 instead of averaging the two elements. The current implementation will not correctly identify the missing number.
    • Add comments to explain the logic in Problem2.java, especially the binary search part, to make it more understandable.
    • Consider adding edge case handling in Problem2.java, such as when the array is empty or has only one element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants