Skip to content

DP-2 Complete Please Review #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vishaljnv wants to merge 2 commits into
base: master
Choose a base branch
from
Open

DP-2 Complete Please Review #1747

vishaljnv wants to merge 2 commits into from

Conversation

@vishaljnv
Copy link

@vishaljnv vishaljnv commented Oct 13, 2025

No description provided.

@super30admin
Copy link
Owner

super30admin commented Oct 13, 2025

  • Strengths: The student has provided both recursive and DP solutions, demonstrating a good understanding of the problem and different approaches to solving it. The DP solution is particularly well-implemented and efficient.
  • Areas for Improvement: The recursive solution could be optimized with memoization to avoid redundant calculations. Additionally, the student could consider adding comments to explain the logic, especially in the DP solution, to enhance readability for others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vishaljnv @super30admin