Skip to content

Conversation

@tanvipandhre
Copy link

Day14 - Merge-sorted-array, Remove-duplicates-from-sorted-array-ii , Search-a-2d-matrix-ii

@super30admin
Copy link
Owner

  • Strengths:
    • The student has a good understanding of the two-pointer technique and has applied it correctly in Problem1 and Problem3.
    • The code is clean, well-structured, and easy to read.
    • The README.md provides a clear explanation of the approach for each problem, which is very helpful.
  • Areas for Improvement:
    • In Problem2, the comparison condition if(nums1[p1] <= nums2[p2]) should be if(nums1[p1] < nums2[p2]) to ensure the correct placement of elements. This is a critical error that needs to be fixed.
    • While the README.md is informative, it could benefit from more detailed explanations of the time and space complexity for each problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants