Skip to content

Fix error annotations #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jakepetroules wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix error annotations #213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 33 additions & 24 deletions .github/workflows/swift_package_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,14 +230,14 @@ jobs:
strategy:
fail-fast: false
matrix:
matrix_enabled:
- ${{ inputs.enable_macos_checks }}
xcode_version: ${{ fromJson(inputs.macos_xcode_versions) }}
os_version: ${{ fromJson(inputs.macos_versions) }}
arch: ${{ fromJson(inputs.macos_archs) }}
exclude:
- ${{ fromJson(inputs.macos_exclude_xcode_versions) }}
- ${{ fromJson((!inputs.enable_macos_checks && inputs.macos_xcode_versions) || '[]') }}
- ${{ fromJson((!inputs.enable_macos_checks && inputs.macos_versions) || '[]') }}
- ${{ fromJson((!inputs.enable_macos_checks && inputs.macos_archs) || '[]') }}
- matrix_enabled: false
steps:
- name: Checkout repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -270,14 +270,14 @@ jobs:
strategy:
fail-fast: false
matrix:
matrix_enabled:
- ${{ inputs.enable_ios_checks }}
xcode_version: ${{ fromJson(inputs.ios_host_xcode_versions || inputs.macos_xcode_versions) }}
os_version: ${{ fromJson(inputs.ios_host_versions || inputs.macos_versions) }}
arch: ${{ fromJson(inputs.ios_host_archs || inputs.macos_archs) }}
exclude:
- ${{ fromJson(inputs.ios_host_exclude_xcode_versions || inputs.macos_exclude_xcode_versions) }}
- ${{ fromJson((!inputs.enable_ios_checks && (inputs.ios_host_xcode_versions || inputs.macos_xcode_versions)) || '[]') }}
- ${{ fromJson((!inputs.enable_ios_checks && (inputs.ios_host_versions || inputs.macos_versions)) || '[]') }}
- ${{ fromJson((!inputs.enable_ios_checks && (inputs.ios_host_archs || inputs.macos_archs)) || '[]') }}
- matrix_enabled: false
steps:
- name: Checkout repository
uses: actions/checkout@v4
Expand Down Expand Up @@ -308,6 +308,8 @@ jobs:
strategy:
fail-fast: false
matrix:
matrix_enabled:
- ${{ inputs.enable_linux_checks }}
swift_version: ${{ fromJson(inputs.linux_swift_versions) }}
os_version: ${{ fromJson(inputs.linux_os_versions) }}
arch: ${{ fromJson(inputs.linux_host_archs) }}
Expand All @@ -322,9 +324,7 @@ jobs:
}}
exclude:
- ${{ fromJson(inputs.linux_exclude_swift_versions) }}
- ${{ fromJson((!inputs.enable_linux_checks && inputs.linux_swift_versions) || '[]') }}
- ${{ fromJson((!inputs.enable_linux_checks && inputs.linux_os_versions) || '[]') }}
- ${{ fromJson((!inputs.enable_linux_checks && inputs.linux_host_archs) || '[]') }}
- matrix_enabled: false
- arch: x86_64
runner: ubuntu-24.04-arm
- arch: aarch64
Expand Down Expand Up @@ -390,6 +390,8 @@ jobs:
strategy:
fail-fast: false
matrix:
matrix_enabled:
- ${{ inputs.enable_linux_static_sdk_build }}
swift_version: ${{ fromJson(inputs.linux_static_sdk_versions) }}
os_version: ${{ fromJson(inputs.linux_os_versions) }}
arch: ${{ fromJson(inputs.linux_host_archs) }}
Expand All @@ -404,9 +406,7 @@ jobs:
}}
exclude:
- ${{ fromJson(inputs.linux_static_sdk_exclude_swift_versions) }}
- ${{ fromJson((!inputs.enable_linux_static_sdk_build && inputs.linux_static_sdk_versions) || '[]') }}
- ${{ fromJson((!inputs.enable_linux_static_sdk_build && inputs.linux_os_versions) || '[]') }}
- ${{ fromJson((!inputs.enable_linux_static_sdk_build && inputs.linux_host_archs) || '[]') }}
- matrix_enabled: false
- arch: x86_64
runner: ubuntu-24.04-arm
- arch: aarch64
Expand Down Expand Up @@ -467,16 +467,19 @@ jobs:

wasm-sdk-build:
name: Swift SDK for Wasm Build (${{ matrix.swift_version }} - ${{ matrix.os_version }})
runs-on: ubuntu-latest
runs-on: ${{ matrix.runner }}
strategy:
fail-fast: false
matrix:
matrix_enabled:
- ${{ inputs.enable_wasm_sdk_build }}
swift_version: ${{ fromJson(inputs.wasm_sdk_versions) }}
os_version: ${{ fromJson(inputs.linux_os_versions) }}
runner:
- ubuntu-latest
exclude:
- ${{ fromJson(inputs.wasm_exclude_swift_versions) }}
- ${{ fromJson((!inputs.enable_wasm_sdk_build && inputs.wasm_sdk_versions) || '[]') }}
- ${{ fromJson((!inputs.enable_wasm_sdk_build && inputs.linux_os_versions) || '[]') }}
- matrix_enabled: false
container:
image: ${{ (contains(matrix.swift_version, 'nightly') && 'swiftlang/swift') || 'swift' }}:${{ matrix.swift_version }}-${{ matrix.os_version }}
steps:
Expand Down Expand Up @@ -533,16 +536,19 @@ jobs:

embedded-wasm-sdk-build:
name: Embedded Swift SDK for Wasm Build (${{ matrix.swift_version }} - ${{ matrix.os_version }})
runs-on: ubuntu-latest
runs-on: ${{ matrix.runner }}
strategy:
fail-fast: false
matrix:
matrix_enabled:
- ${{ inputs.enable_embedded_wasm_sdk_build }}
runner:
- ubuntu-latest
swift_version: ${{ fromJson(inputs.wasm_sdk_versions) }}
os_version: ${{ fromJson(inputs.linux_os_versions) }}
exclude:
- ${{ fromJson(inputs.wasm_exclude_swift_versions) }}
- ${{ fromJson((!inputs.enable_embedded_wasm_sdk_build && inputs.wasm_sdk_versions) || '[]') }}
- ${{ fromJson((!inputs.enable_embedded_wasm_sdk_build && inputs.linux_os_versions) || '[]') }}
- matrix_enabled: false
container:
image: ${{ (contains(matrix.swift_version, 'nightly') && 'swiftlang/swift') || 'swift' }}:${{ matrix.swift_version }}-${{ matrix.os_version }}
steps:
Expand Down Expand Up @@ -599,18 +605,20 @@ jobs:

android-sdk-build:
name: Swift SDK for Android Build (${{ matrix.swift_version }} - ${{ matrix.os_version }} - NDK ${{ matrix.ndk_version }})
runs-on: ubuntu-latest
Copy link
Contributor Author

@jakepetroules jakepetroules Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks useless but interestingly making runs-on dependent on a matrix entry rather than a string literal prevents it from creating a job with an empty configuration when the matrix is empty.

runs-on: ${{ matrix.runner }}
strategy:
fail-fast: false
matrix:
matrix_enabled:
- ${{ inputs.enable_android_sdk_build }}
runner:
- ubuntu-latest
swift_version: ${{ fromJson(inputs.android_sdk_versions) }}
ndk_version: ${{ fromJson(inputs.android_ndk_versions) }}
os_version: ${{ fromJson(inputs.linux_os_versions) }}
exclude:
- ${{ fromJson(inputs.android_exclude_swift_versions) }}
- ${{ fromJson((!inputs.enable_android_sdk_build && inputs.android_sdk_versions) || '[]') }}
- ${{ fromJson((!inputs.enable_android_sdk_build && inputs.android_ndk_versions) || '[]') }}
- ${{ fromJson((!inputs.enable_android_sdk_build && inputs.linux_os_versions) || '[]') }}
- matrix_enabled: false
container:
image: ${{ (contains(matrix.swift_version, 'nightly') && 'swiftlang/swift') || 'swift' }}:${{ matrix.swift_version }}-${{ matrix.os_version }}
steps:
Expand Down Expand Up @@ -671,12 +679,13 @@ jobs:
strategy:
fail-fast: false
matrix:
matrix_enabled:
- ${{ inputs.enable_windows_checks }}
swift_version: ${{ fromJson(inputs.windows_swift_versions) }}
os_version: ${{ fromJson(inputs.windows_os_versions) }}
exclude:
- ${{ fromJson(inputs.windows_exclude_swift_versions) }}
- ${{ fromJson((!inputs.enable_windows_checks && inputs.windows_swift_versions) || '[]') }}
- ${{ fromJson((!inputs.enable_windows_checks && inputs.windows_os_versions) || '[]') }}
- matrix_enabled: false
steps:
- name: Checkout repository
uses: actions/checkout@v4
Expand Down