Improve PIFBuilder testability by exposing PackagePIFBuilder objects #9501
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Improve
PIFBuildertestability by exposing all intermediaryPackagePIFBuilderobjects created during PIF construction.For instance, this something we need to be able to add the required tests for PR #9436, where a fix was made to how
PackagePIFBuildercomputes some PIF metadata not directly used by SwiftPM (only by Xcode, and potentially other external clients too).Modifications:
This PR extracts the following intermediary function from the existing — and very long! —
PIFBuilder.constructPIFoperation:...allowing it to be unit tested too! No new features are actually added — just plain refactoring :-)
Result:
Improved testability in
SwiftBuildSupport.PIFBuilderclass.