-
Notifications
You must be signed in to change notification settings - Fork 0
Hud improvements #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Hud improvements #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Complete Refactoring
We successfully refactored the HUD flow diagram system with clean separation of concerns:
Architecture:
FlowDiagramFrame (viewport management)
├── @width, @height (viewport size)
├── Pan offsets & centering logic
├── ClippedTerminal wrapper
└── Wraps FlowDiagram
ClippedTerminal (boundary enforcement)
└── Clips all writes to viewport
FlowDiagram (pure renderer)
├── No viewport state (@width/@height removed)
├── Renders in coordinate space starting at (0,0)
├── Returns content dimensions: { width:, height: }
└── Zero clipping logic
Key Improvements:
✅ FlowDiagram is completely viewport-agnostic
✅ All clipping handled by ClippedTerminal
✅ Centering/panning managed by FlowDiagramFrame
✅ Zero redundancy between classes
✅ Clean naming (width/height instead of diagram_width/diagram_height)
✅ All 635 tests passing