Skip to content

Conversation

@wesleyvandermeer
Copy link

Add important note about Git-Clone ssh authentication.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

Add important note about Git-Clone ssh authentication.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 11, 2024

CLA Not Signed

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 11, 2024
@wesleyvandermeer wesleyvandermeer changed the title Update clone-repository.md Add important note about SSH authentication. May 11, 2024
Renamed info to information. 
Bump CLA check.
@wesleyvandermeer
Copy link
Author

/retest

@tekton-robot
Copy link

@wesleyvandermeer: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Comment on lines +333 to +334
> [!IMPORTANT]
> When using **Git-Clone** you should make sure that your private key is in the correct format. Libcrypto requires you to have a new line at the end of your private_key (PEM) format. Checkout: https://github.com/tektoncd/catalog/issues/1220 for more information.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR.
I guess this would belong in the documentation of the git-clone task, but it doesn't harm here, so it's fine.
Since you're updating this, would you mind ypdating line 331 as well, with the latest version of the task (https://raw.githubusercontent.com/tektoncd-catalog/git-clone/refs/heads/release-v1.1.x/task/git-clone/git-clone.yaml) ?

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants