-
Notifications
You must be signed in to change notification settings - Fork 166
Add important note about SSH authentication. #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add important note about Git-Clone ssh authentication.
|
Renamed info to information. Bump CLA check.
|
/retest |
|
@wesleyvandermeer: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
afrittoli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
| > [!IMPORTANT] | ||
| > When using **Git-Clone** you should make sure that your private key is in the correct format. Libcrypto requires you to have a new line at the end of your private_key (PEM) format. Checkout: https://github.com/tektoncd/catalog/issues/1220 for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR.
I guess this would belong in the documentation of the git-clone task, but it doesn't harm here, so it's fine.
Since you're updating this, would you mind ypdating line 331 as well, with the latest version of the task (https://raw.githubusercontent.com/tektoncd-catalog/git-clone/refs/heads/release-v1.1.x/task/git-clone/git-clone.yaml) ?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add important note about Git-Clone ssh authentication.
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.