Skip to content

fix hidden flag property #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stephanos wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix hidden flag property #893

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions internal/commandsgen/code.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,5 +492,8 @@ func (o *Option) writeFlagBuilding(selfVar, flagVar string, w *codeWriter) error
if o.Deprecated != "" {
w.writeLinef("_ = %v.MarkDeprecated(%q, %q)", flagVar, o.Name, o.Deprecated)
}
if o.Hidden {
w.writeLinef("_ = %v.MarkHidden(%q)", flagVar, o.Name)
}
return nil
}
1 change: 1 addition & 0 deletions internal/commandsgen/parse.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ type (
Aliases []string `yaml:"aliases,omitempty"`
EnumValues []string `yaml:"enum-values,omitempty"`
Experimental bool `yaml:"experimental,omitempty"`
Hidden bool `yaml:"hidden,omitempty"`
HiddenLegacyValues []string `yaml:"hidden-legacy-values,omitempty"`
}

Expand Down
2 changes: 0 additions & 2 deletions internal/temporalcli/commands.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3475,7 +3475,6 @@ commands:
- name: queue-rps-limit-reason
type: string
description: Reason for queue rate limit update.
hidden: true
Copy link
Contributor Author

@stephanos stephanos Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with the team and this is not actually desirable.

- name: fairness-key-rps-limit-default
type: string
display-type: float|default
Expand All @@ -3485,7 +3484,6 @@ commands:
- name: fairness-key-rps-limit-reason
type: string
description: Reason for fairness key rate limit update.
hidden: true

- name: temporal workflow
summary: Start, list, and operate on Workflows
Expand Down
Loading