-
Notifications
You must be signed in to change notification settings - Fork 642
Add Jupyter Notebook Format Check to format_check.sh #902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@mhucka Please review these changes when you have a chance. |
I dont think this CI check fail related to these changes , please correct me if i am wrong also i'm getting same check fail in other #903 |
|
Thanks for this. I think it will be better to take this in a different direction, and use @Aniketsy Let us know if you would like to update this PR accordingly. No worries if you do not have the time or are not interested in pursuing it. |
|
@mhucka Thanks for the feedback. I’ll update the code with the suggested changes. |
0864e6b to
bcf9452
Compare
checked locally, @mhucka please, let me know if this needs further improvement. |
b4916c7 to
a79d15d
Compare
#681
This PR adds a check to format_check.sh to ensure all Jupyter Notebook (.ipynb) files are in the correct format before merging. The script now uses nbstripout --check to verify that notebooks do not contain unwanted outputs or metadata.
Please let me know if this fix needs any improvements . I’m open to feedback and happy to make changes based on suggestions.
Thankyou!