-
-
Notifications
You must be signed in to change notification settings - Fork 4
Updated reamde and filter jpeg4py and pillow-simd on Mac OS #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request updates the benchmark script to exclude jpeg4py and pillow-simd on macOS, increases the number of benchmark runs, adds a citation section to the README, and updates the ruff pre-commit hook. State diagram for benchmark configuration changesstateDiagram-v2
[*] --> Configuration
Configuration --> DefaultConfig
DefaultConfig: num_images = 2000
DefaultConfig: num_runs = 20 (increased from 5)
DefaultConfig --> LibrarySelection
LibrarySelection --> MacOSLibs: If macOS
LibrarySelection --> AllLibs: If other OS
MacOSLibs: Exclude jpeg4py
MacOSLibs: Exclude pillow-simd
AllLibs: Include all libraries
MacOSLibs --> BenchmarkExecution
AllLibs --> BenchmarkExecution
BenchmarkExecution --> [*]
Flow diagram for updated benchmark library selection processflowchart TD
A[Start Library Selection] --> B{Check OS}
B -->|macOS| C[Filter Libraries]
B -->|Other OS| D[Use All Libraries]
C -->|Remove jpeg4py| E[Filtered List 1]
E -->|Remove pillow-simd| F[Final macOS Libraries]
D --> G[All Libraries List]
F --> H[Return Library List]
G --> H
H --> I[End]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes - here's some feedback:
Overall Comments:
- The citation includes a future year (2025) which may need to be updated to the current or expected publication year.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Update benchmark script to skip jpeg4py and pillow-simd on macOS, increase default runs to 20, and add citation information to the README.
Build:
Documentation: