👽 Support ecodev/graphql-upload v8 #268
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homersimpsons
commented
Dec 11, 2025
homersimpsons
force-pushed
the
fix/support-ecodev-graphql-upload-v8
branch
2 times, most recently
from
07a4a76 to
00e934b
Compare
homersimpsons
force-pushed
the
fix/support-ecodev-graphql-upload-v8
branch
from
00e934b to
5114346
Compare
andrew-demb
reviewed
Dec 11, 2025
| */ | ||
| class RequestExtractorMiddleware implements RequestHandlerInterface | ||
| { | ||
| public function handle(ServerRequestInterface $request): ResponseInterface |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
andrew-demb
reviewed
Dec 11, 2025
| use Psr\Http\Message\ServerRequestInterface; | ||
|
|
||
| /** | ||
| * Class used to allow extraction of request from PSR-15 middleware |
Collaborator
There was a problem hiding this comment.
please mark introduced classes with @internal tag to avoid using them from the outside
andrew-demb
reviewed
Dec 11, 2025
| $psr7Request = $uploadMiddleware->processRequest($psr7Request); | ||
| \assert($psr7Request instanceof ServerRequestInterface); | ||
| $dummyResponseWithRequest = $uploadMiddleware->process($psr7Request, new RequestExtractorMiddleware()); | ||
| assert($dummyResponseWithRequest instanceof DummyResponseWithRequest); |
Collaborator
There was a problem hiding this comment.
This code is not so strict as to be sure that you will have a DummyResponseWithRequest instance.
I suggest to use if + throw in case of unexpected result
andrew-demb
reviewed
Dec 11, 2025
|
|
||
| /** | ||
| * Listens to every single request and forward Graphql requests to Graphql Webonix standardServer. | ||
| * Listens to every single request and forwards GraphQL requests to Webonyx's \GraphQL\Server\StandardServer. |
Collaborator
There was a problem hiding this comment.
Suggested change
| * Listens to every single request and forwards GraphQL requests to Webonyx's \GraphQL\Server\StandardServer. | |
| * Listens to every single request and forwards GraphQL requests to Webonyx's {@see \GraphQL\Server\StandardServer}. |
Collaborator
I'm OK with introducing it for the v6, we too had problems with update graphqlite to v8. Let's retarget to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #259
Note that there are two alternative implementations:
Note that the anonymous class declaration is rather verbose and would have been simplified by https://wiki.php.net/rfc/property-capture
DummyResponseWithRequestallowing us to extract the ecodev/graphql-upload psr7 request from the middleware chain to allow passing it in our previous symfony flow.@andrew-demb note that I would like this for the v6 of this package, how would you like to proceed?