Skip to content

(ts-api-react-actions) Enhance error handling in API actions and hooks with user-facing error mapping #1616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Oksamies wants to merge 4 commits into
base: 11-19-refactor_api_methods_to_remove_unnecessary_async_await_and_improve_return_handling
Choose a base branch
from
Open

(ts-api-react-actions) Enhance error handling in API actions and hooks with user-facing error mapping #1616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d34702c
(ts-api-react-actions) Enhance error handling in API actions and hook…
Oksamies Dec 2, 2025
4a25139
Refactor loader functions to enhance error handling and move to diffe…
Oksamies Dec 2, 2025
689944f
Enhance error handling in StrongForm and useFormToaster with user-fac…
Oksamies Dec 2, 2025
de2572f
Correct error handling related imports and types
Oksamies Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/cyberstorm-remix/app/p/components/ReportPackage/ReportPackageForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {
import {
type PackageListingReportRequestData,
type RequestConfig,
UserFacingError,
packageListingReport,
} from "@thunderstore/thunderstore-api";

Expand Down Expand Up @@ -81,7 +82,7 @@ export function ReportPackageForm(
PackageListingReportRequestData,
Error,
SubmitorOutput,
Error,
UserFacingError,
InputErrors
>({
inputs: formInputs,
Expand Down
3 changes: 2 additions & 1 deletion apps/cyberstorm-remix/app/p/packageEdit.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import { DapperTs } from "@thunderstore/dapper-ts";
import {
ApiError,
type PackageListingUpdateRequestData,
UserFacingError,
packageDeprecate,
packageListingUpdate,
packageUnlist,
Expand Down Expand Up @@ -214,7 +215,7 @@ export default function PackageListing() {
PackageListingUpdateRequestData,
Error,
SubmitorOutput,
Error,
UserFacingError,
InputErrors
>({
inputs: formInputs,
Expand Down
3 changes: 2 additions & 1 deletion apps/cyberstorm-remix/app/p/tabs/Wiki/WikiNewPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import {
import { classnames } from "@thunderstore/cyberstorm";
import {
type PackageWikiPageCreateRequestData,
UserFacingError,
postPackageWikiPageCreate,
} from "@thunderstore/thunderstore-api";

Expand Down Expand Up @@ -111,7 +112,7 @@ export default function Wiki() {
PackageWikiPageCreateRequestData,
Error,
SubmitorOutput,
Error,
UserFacingError,
InputErrors
>({
inputs: formInputs,
Expand Down
3 changes: 2 additions & 1 deletion apps/cyberstorm-remix/app/p/tabs/Wiki/WikiPageEdit.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import {
type PackageWikiPageEditRequestData,
type PackageWikiPageResponseData,
type RequestConfig,
UserFacingError,
deletePackageWikiPage,
postPackageWikiPageEdit,
} from "@thunderstore/thunderstore-api";
Expand Down Expand Up @@ -181,7 +182,7 @@ export default function WikiEdit() {
PackageWikiPageEditRequestData,
Error,
SubmitorOutput,
Error,
UserFacingError,
InputErrors
>({
inputs: formInputs,
Expand Down
3 changes: 2 additions & 1 deletion apps/cyberstorm-remix/app/settings/teams/Teams.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import { postTeamCreate } from "@thunderstore/dapper-ts";
import {
type RequestConfig,
type TeamCreateRequestData,
UserFacingError,
teamCreate,
} from "@thunderstore/thunderstore-api";
import {
Expand Down Expand Up @@ -161,7 +162,7 @@ function CreateTeamForm(props: { config: () => RequestConfig }) {
TeamCreateRequestData,
Error,
SubmitorOutput,
Error,
UserFacingError,
InputErrors
>({
inputs: formInputs,
Expand Down
3 changes: 2 additions & 1 deletion apps/cyberstorm-remix/app/settings/teams/team/tabs/Members/MemberAddForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import {
import {
type RequestConfig,
type TeamAddMemberRequestData,
UserFacingError,
teamAddMember,
} from "@thunderstore/thunderstore-api";

Expand Down Expand Up @@ -69,7 +70,7 @@ export function MemberAddForm(props: {
TeamAddMemberRequestData,
Error,
SubmitorOutput,
Error,
UserFacingError,
InputErrors
>({
inputs: formInputs,
Expand Down
3 changes: 2 additions & 1 deletion apps/cyberstorm-remix/app/settings/teams/team/tabs/Profile/Profile.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { NewButton, NewTextInput, useToast } from "@thunderstore/cyberstorm";
import {
type TeamDetails,
type TeamDetailsEditRequestData,
UserFacingError,
teamDetailsEdit,
} from "@thunderstore/thunderstore-api";

Expand Down Expand Up @@ -86,7 +87,7 @@ function ProfileForm(props: { team: TeamDetails }) {
TeamDetailsEditRequestData,
Error,
SubmitorOutput,
Error,
UserFacingError,
InputErrors
>({
inputs: formInputs,
Expand Down
3 changes: 2 additions & 1 deletion apps/cyberstorm-remix/app/settings/teams/team/tabs/ServiceAccounts/ServiceAccounts.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import {
} from "@thunderstore/cyberstorm";
import {
type TeamServiceAccountAddRequestData,
UserFacingError,
teamAddServiceAccount,
} from "@thunderstore/thunderstore-api";

Expand Down Expand Up @@ -136,7 +137,7 @@ function AddServiceAccountForm(props: {
TeamServiceAccountAddRequestData,
Error,
SubmitorOutput,
Error,
UserFacingError,
InputErrors
>({
inputs: formInputs,
Expand Down
3 changes: 2 additions & 1 deletion apps/cyberstorm-remix/app/settings/teams/team/tabs/Settings/Settings.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import {
import {
type RequestConfig,
type TeamDisbandRequestData,
UserFacingError,
teamDisband,
teamRemoveMember,
} from "@thunderstore/thunderstore-api";
Expand Down Expand Up @@ -257,7 +258,7 @@ function DisbandTeamForm(props: {
TeamDisbandRequestData,
Error,
SubmitorOutput,
Error,
UserFacingError,
InputErrors
>({
inputs: formInputs,
Expand Down
4 changes: 2 additions & 2 deletions apps/cyberstorm-remix/app/settings/user/Account/Account.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import {
NewTextInput,
useToast,
} from "@thunderstore/cyberstorm";
import { userDelete } from "@thunderstore/thunderstore-api";
import { UserFacingError, userDelete } from "@thunderstore/thunderstore-api";

import "./Account.css";

Expand Down Expand Up @@ -126,7 +126,7 @@ function DeleteAccountForm(props: {
UserAccountDeleteRequestData,
Error,
SubmitorOutput,
Error,
UserFacingError,
InputErrors
>({
inputs: formInputs,
Expand Down
7 changes: 5 additions & 2 deletions apps/cyberstorm-remix/app/upload/upload.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,10 @@ import {
postPackageSubmissionMetadata,
} from "@thunderstore/dapper-ts";
import { DnDFileInput } from "@thunderstore/react-dnd";
import { type PackageSubmissionRequestData } from "@thunderstore/thunderstore-api";
import {
type PackageSubmissionRequestData,
UserFacingError,
} from "@thunderstore/thunderstore-api";
import {
type IBaseUploadHandle,
MultipartUpload,
Expand Down Expand Up @@ -332,7 +335,7 @@ export default function Upload() {
PackageSubmissionRequestData,
Error,
SubmitorOutput,
Error,
UserFacingError,
InputErrors
>({
inputs: formInputs,
Expand Down
Loading
Loading