Update depedency versions #1654
Conversation
WalkthroughThis pull request updates dependency versions across multiple packages and applications. React ecosystem packages are upgraded from version 19.1.x to 19.2.x across all packages and apps. Additionally, the Cyberstorm Remix application receives updates to routing packages, Sentry integrations, remix-utils, and Vite. The Storybook application updates Vite. The plop template for React package generation is modified to reference React version 19.2.1 instead of 18.2.0. No changes to code logic, control flow, or public APIs are present. Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| "@types/react": "^18.0.0", | ||
| "react": "^18.2.0", | ||
| "react-dom": "^18.2.0" | ||
| "react": "^19.2.1", | ||
| "react-dom": "^19.2.1" |
There was a problem hiding this comment.
Type definition version mismatch detected. The @types/react is still at ^18.0.0 while react and react-dom have been updated to ^19.2.1. This will cause TypeScript compilation errors due to incompatible type definitions.
Fix:
"@types/react": "^19.2.7",
"react": "^19.2.1",
"react-dom": "^19.2.1"| "@types/react": "^18.0.0", | |
| "react": "^18.2.0", | |
| "react-dom": "^18.2.0" | |
| "react": "^19.2.1", | |
| "react-dom": "^19.2.1" | |
| "@types/react": "^19.2.7", | |
| "react": "^19.2.1", | |
| "react-dom": "^19.2.1" |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (11)
apps/cyberstorm-remix/package.json(2 hunks)apps/storybook/package.json(1 hunks)packages/cyberstorm-forms/package.json(1 hunks)packages/cyberstorm/package.json(1 hunks)packages/dapper/package.json(1 hunks)packages/react-dnd/package.json(1 hunks)packages/ts-api-react-actions/package.json(1 hunks)packages/ts-api-react-forms/package.json(1 hunks)packages/ts-api-react/package.json(1 hunks)packages/ts-uploader-react/package.json(1 hunks)plop/package/package.json.hbs(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-10-01T11:36:11.065Z
Learnt from: anttimaki
Repo: thunderstore-io/thunderstore-ui PR: 1559
File: packages/ts-api-react/package.json:16-18
Timestamp: 2025-10-01T11:36:11.065Z
Learning: In the thunderstore-ui repository, exact Node version pinning (e.g., "24.9.0") is intentionally used in package.json engines fields rather than semver ranges, to ensure consistency across environments.
Applied to files:
packages/ts-api-react-actions/package.jsonapps/cyberstorm-remix/package.jsonpackages/ts-api-react/package.jsonpackages/ts-uploader-react/package.jsonapps/storybook/package.jsonpackages/cyberstorm/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Build
- GitHub Check: Generate visual diffs
🔇 Additional comments (13)
packages/ts-api-react/package.json (1)
21-23: React 19.2.x bump here looks consistent with the rest of the repoThe @types/react, react, and react-dom versions are aligned and match the broader PR changes. No issues from this file alone; just ensure the lockfile is updated and CI passes after the upgrade.
packages/cyberstorm-forms/package.json (1)
29-31: Form package React deps are cleanly aligned to 19.2.xThe React and @types/react bumps here are consistent with the rest of the monorepo and should keep forms in sync with host apps. Nothing concerning from this diff; just let CI confirm everything still type-checks and builds.
packages/react-dnd/package.json (1)
17-19: React DnD hooks package now aligned to React 19.2.xThe React and @types/react versions are bumped consistently with the rest of the monorepo. Looks good from here; just confirm via CI that type-checking and bundles for
@thunderstore/react-dndstay green after the upgrade.packages/ts-uploader-react/package.json (1)
18-20: Uploader React package deps updated coherently to 19.2.xThe @types/react, react, and react-dom versions here match the rest of the upgraded React stack. No concerns from this diff; just ensure the lockfile and any consuming apps (e.g., Storybook, Cyberstorm) still build and run as expected.
apps/storybook/package.json (1)
24-25: Storybook React + Vite bumps look reasonable; verify the builder still behavesReact/@types and Vite are all moved to newer 19.2.x / 7.2.x versions and are consistent with the rest of the repo. From the manifest alone this looks fine; just make sure to run the Storybook flows (
storybook dev/storybook build) so any Vite + Storybook + React 19.2 integration issues are caught by CI instead of later.Also applies to: 29-30, 34-34
packages/dapper/package.json (1)
30-32: Dapper’s React context deps are now aligned with React 19.2.xThe React and @types/react versions are in sync with other packages and should keep this shared context provider on the same major/minor as its consumers. No problems evident here; just rely on CI and integration usage (e.g., Cyberstorm, Storybook) to confirm everything still compiles and runs.
packages/ts-api-react-actions/package.json (1)
20-22: Actions package React deps match the upgraded API React packageThe React/@types versions here are aligned with
@thunderstore/ts-api-reactand the rest of the repo’s React 19.2.x migration. Looks good; just confirm via CI that the combinedts-api-react+ts-api-react-actionsusage still type-checks and builds cleanly.packages/cyberstorm/package.json (1)
38-38: React ecosystem upgraded to 19.2.x.These updates align with the monorepo-wide React 19.2 migration and maintain consistent caret ranges for patch flexibility.
Also applies to: 40-40, 42-42
packages/ts-api-react-forms/package.json (1)
21-23: React ecosystem upgraded to 19.2.x.Straightforward alignment with monorepo-wide React 19.2 migration.
apps/cyberstorm-remix/package.json (4)
40-40: Verify remix-utils 9.0.0 breaking changes.The jump from 7.7.0 to 9.0.0 is a major version bump that may introduce breaking changes. Please verify compatibility and ensure any required code updates are applied.
19-20: Verify @React-router package compatibility with React 19.2.1.The @React-router suite updates to 7.10.0 (from 7.6.2/7.0.0) should be compatible with React 19.2.1 per semver, but framework routing packages can have subtle integration requirements. Confirm the update doesn't introduce routing or SSR issues.
Also applies to: 36-36, 45-45
47-47: Clarify exact pinning of @types/react-dom.Line 47 pins @types/react-dom to exact version 19.2.3, while other React type definitions use caret ranges (^19.2.7). Is this intentional, or should it align with the ^ pattern used elsewhere (e.g., line 46)?
33-34: React ecosystem upgrades to 19.2.x.Core React and type updates align with the monorepo-wide migration. Verify integrations with @React-router and remix-utils (noted in separate comments above).
Also applies to: 46-46
| "@types/react": "^18.0.0", | ||
| "react": "^18.2.0", | ||
| "react-dom": "^18.2.0" | ||
| "react": "^19.2.1", | ||
| "react-dom": "^19.2.1" |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
# Search for @types/react references across package.json files
fd -e "package.json" -o -e "package.json.hbs" --type f | head -20 | xargs -I {} sh -c 'echo "=== {} ===" && cat "{}" | grep -A 1 -B 1 "@types/react" 2>/dev/null || echo "no match"'Repository: thunderstore-io/thunderstore-ui
Length of output: 191
🏁 Script executed:
# Get a broader view: search for @types/react in all package.json files
rg "@types/react" --type json -A 1 -B 1Repository: thunderstore-io/thunderstore-ui
Length of output: 2666
Align @types/react version in the template with React 19.2.x
The template currently scaffolds:
@types/react:^18.0.0react:^19.2.1react-dom:^19.2.1
Any new React package generated from this template will have React 19.2.x at runtime but React 18 type definitions. All other packages in the repo use @types/react@^19.2.7, creating an inconsistency that can lead to type mismatches.
Update to keep them in sync:
- "@types/react": "^18.0.0",
+ "@types/react": "^19.2.7",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@types/react": "^18.0.0", | |
| "react": "^18.2.0", | |
| "react-dom": "^18.2.0" | |
| "react": "^19.2.1", | |
| "react-dom": "^19.2.1" | |
| "@types/react": "^19.2.7", | |
| "react": "^19.2.1", | |
| "react-dom": "^19.2.1" |
🤖 Prompt for AI Agents
In plop/package/package.json.hbs around lines 21 to 23, the template pins
@types/react to ^18.0.0 while react and react-dom are ^19.2.1, causing
type/runtime mismatch; update the @types/react entry to match the repo's React
19.x (e.g. ^19.2.7 or ^19.2.x) so the generated package.json uses @types/react
compatible with React 19, and run a quick template lint or install to verify no
type errors.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1654 +/- ##
=======================================
Coverage 10.82% 10.82%
=======================================
Files 315 315
Lines 22684 22684
Branches 463 463
=======================================
Hits 2455 2455
Misses 20229 20229 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.