Skip to content

Conversation

@anttimaki
Copy link
Contributor

  • Disable team profile form for non-owners, making it read-only for members
  • Adjust hover styles of disabled text inputs and buttons to make their state obvious
  • I'd like to add a simple URL validator for the input, but I want to see where the
    previous PR in this stack goes first as it will likely affect the implementation

Backend requires owner-level permissions so no point waste other
member's time by letting them fiddle with the form.

I considered creating entirely separate component for viewing the data,
which would save us from having to set up strongForm for no reason,
but given there's no reusable components, it would repeat a lot of
markup and lead to poor maintainability.
Change the on-hover cursor when to indicate the input is disabled.
Remove pointer-events: none rule from disabled buttons so they show the
default on-hover cursor for them.
@anttimaki anttimaki requested a review from Oksamies December 10, 2025 08:53
@coderabbitai
Copy link

coderabbitai bot commented Dec 10, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch team-profile-form

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 11.53%. Comparing base (e53f68a) to head (036d512).

Files with missing lines Patch % Lines
...x/app/settings/teams/team/tabs/Profile/Profile.tsx 0.00% 8 Missing ⚠️
Additional details and impacted files
@@                                        Coverage Diff                                        @@
##           12-09-improve_strongform_validation_ux_and_text_input_styling    #1662      +/-   ##
=================================================================================================
- Coverage                                                          11.55%   11.53%   -0.02%     
=================================================================================================
  Files                                                                317      317              
  Lines                                                              22955    22962       +7     
  Branches                                                             508      506       -2     
=================================================================================================
- Hits                                                                2652     2649       -3     
- Misses                                                             20303    20313      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants