-
Notifications
You must be signed in to change notification settings - Fork 8
Detector library examples #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Detector library examples #118
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
==========================================
+ Coverage 83.79% 83.89% +0.09%
==========================================
Files 47 47
Lines 3086 3105 +19
==========================================
+ Hits 2586 2605 +19
Misses 500 500 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks @georgeoshardo! This would be a nice pattern to establish. On thought I'm having is that it would be nice to pull these QE from FPbase, similar to how we pull fluorophore spectra (see https://github.com/tlambert03/microsim/blob/main/src/microsim/schema/sample/fluorophore.py) I believe we have all these QE curves in FPbase, but if not we should add them there. I'm afk right now, but let me know it it's not clear how to grab from FPbase |
|
As for modeling the nonuniformity, that would also be great. I ideally want something like a mixed Gaussian read noise distribution model (as opposed to actually storing a noise/gain/offset map for each camera). There is some prior art out there, but I haven't had time to look around for it |
Great idea
Not these specific sensors, but I shall submit them, and then grab from FPbase! |
Hi @tlambert03, I've added a couple of extra example detectors, one for CMOS and one for EMCCD.
I thought I'd add these because I'm currently in the process of trying to extend the CMOS class to include dark signal and photo response non uniformities across pixels (to model the pattern noise in my data) sometimes seen in CMOS images. Let me know what you think