Skip to content

Conversation

@georgeoshardo
Copy link

Hi @tlambert03, I've added a couple of extra example detectors, one for CMOS and one for EMCCD.

I thought I'd add these because I'm currently in the process of trying to extend the CMOS class to include dark signal and photo response non uniformities across pixels (to model the pattern noise in my data) sometimes seen in CMOS images. Let me know what you think

@codecov
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.89%. Comparing base (166bf87) to head (46fb98f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   83.79%   83.89%   +0.09%     
==========================================
  Files          47       47              
  Lines        3086     3105      +19     
==========================================
+ Hits         2586     2605      +19     
  Misses        500      500              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tlambert03
Copy link
Owner

Thanks @georgeoshardo! This would be a nice pattern to establish.

On thought I'm having is that it would be nice to pull these QE from FPbase, similar to how we pull fluorophore spectra (see https://github.com/tlambert03/microsim/blob/main/src/microsim/schema/sample/fluorophore.py)

I believe we have all these QE curves in FPbase, but if not we should add them there.

I'm afk right now, but let me know it it's not clear how to grab from FPbase

@tlambert03
Copy link
Owner

As for modeling the nonuniformity, that would also be great. I ideally want something like a mixed Gaussian read noise distribution model (as opposed to actually storing a noise/gain/offset map for each camera). There is some prior art out there, but I haven't had time to look around for it

@georgeoshardo
Copy link
Author

On thought I'm having is that it would be nice to pull these QE from FPbase, similar to how we pull fluorophore spectra (see https://github.com/tlambert03/microsim/blob/main/src/microsim/schema/sample/fluorophore.py)

Great idea

I believe we have all these QE curves in FPbase, but if not we should add them there.

Not these specific sensors, but I shall submit them, and then grab from FPbase!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants