-
Notifications
You must be signed in to change notification settings - Fork 2
Merging the changes from aviyan-windows-testing and aviyan-macro-heatmap #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aveeyan
wants to merge
24
commits into
tomasohara:main
Choose a base branch
from
aveeyan:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… alternatives for some lines
… files and previewing failure report analysis; macro_failure_analyzer now uses file grob pattern instead of directory string
… Mezclafy the scripts)
…mmands based on batspp-output/ output files
…-fication of script remains
… and system libraries with mezcla ones; Added tests/test_failure_analyzer.py
…tion to run failure analysis
…es for API and CLI options; Added war stories from debugging
…epetitive codes; Included helper functions in tests for instantiating class in API tests and abstract the script execution
tomasohara
reviewed
Oct 9, 2025
Owner
tomasohara
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wanted the old stuff in a PR (i.e., stuff for which you forked a branch). The new coverage stuff should be in a branch and shouldn't be in a fork as mentioned a while back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes are related to the creation of failure_analyzer.py and generate_macro_heatmap.py (and their test scripts).
aviyan-windows-testing branch consists of failure_analyzer.py, its tests and the changes made to the Jupyter Notebook tests (mostly the addition of # Global Setup to source the aliases). The results were compared along WSL, Cygwin, Ubuntu 24.04 Docker and Ubuntu 24.04.
aviyan-macro-heatmap consists of generate_macro_heatmap.py, which presents both TSV reports and an interactive web report that shows the heatmap of the coverage of macros in the testfiles.