Skip to content

feat: build proto with updated markup type #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eisbilir wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: build proto with updated markup type #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions clients/client-relational/bin/gen-stubs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ const protoConfig = [
`--ts_proto_opt=Mgoogle/protobuf/struct.proto=@topcoder-framework/lib-common`,
`--ts_proto_opt=Mgoogle/protobuf/timestamp.proto=@topcoder-framework/lib-common`,
`--proto_path ${PROTO_DIR} ${PROTO_DIR}/data-access-layer/relational/*.proto`,
`--experimental_allow_proto3_optional`,
];

// https://github.com/stephenh/ts-proto#usage
Expand Down
1 change: 1 addition & 0 deletions domains/domain-acl/bin/gen-stubs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ const protoConfig = [
`--ts_proto_opt=Mgoogle/protobuf/empty.proto=@topcoder-framework/lib-common`,
`--proto_path ${PROTO_DIR} ${PROTO_DIR}/domain-layer/legacy/*.proto`,
`--proto_path ${PROTO_DIR} ${PROTO_DIR}/domain-layer/legacy/services/*.proto`,
`--experimental_allow_proto3_optional`,
];

// https://github.com/stephenh/ts-proto#usage
Expand Down
1 change: 1 addition & 0 deletions domains/domain-challenge/bin/gen-stubs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ const protoConfig = [
`--ts_proto_opt=Mgoogle/protobuf/empty.proto=@topcoder-framework/lib-common`,
`--proto_path ${PROTO_DIR} ${PROTO_DIR}/domain-layer/challenge/*.proto`,
`--proto_path ${PROTO_DIR} ${PROTO_DIR}/domain-layer/challenge/services/*.proto`,
`--experimental_allow_proto3_optional`,
];

// https://github.com/stephenh/ts-proto#usage
Expand Down
6 changes: 3 additions & 3 deletions domains/domain-challenge/src/models/domain-layer/challenge/challenge.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1166,7 +1166,7 @@ export const Challenge_Billing = {
writer.uint32(8).int32(message.billingAccountId);
}
if (message.markup !== 0) {
writer.uint32(21).float(message.markup);
writer.uint32(17).double(message.markup);
}
return writer;
},
Expand All @@ -1187,11 +1187,11 @@ export const Challenge_Billing = {
message.billingAccountId = reader.int32();
continue;
case 2:
if (tag !== 21) {
if (tag !== 17) {
break;
}

message.markup = reader.float();
message.markup = reader.double();
continue;
}
if ((tag & 7) === 4 || tag === 0) {
Expand Down
1 change: 1 addition & 0 deletions lib/lib-common/bin/gen-stubs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ const protoConfig = [
`--ts_proto_opt=outputClientImpl=true`,
`--ts_proto_out=${MODEL_DIR}`,
`--proto_path ${PROTO_DIR} ${PROTO_DIR}/common/*.proto`,
`--experimental_allow_proto3_optional`,
];

// https://github.com/stephenh/ts-proto#usage
Expand Down
2 changes: 2 additions & 0 deletions lib/lib-common/src/models/google/protobuf/empty.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ import _m0 from "protobufjs/minimal";
* service Foo {
* rpc Bar(google.protobuf.Empty) returns (google.protobuf.Empty);
* }
*
* The JSON representation for `Empty` is empty JSON object `{}`.
*/
export interface Empty {}

Expand Down
4 changes: 2 additions & 2 deletions lib/lib-common/src/models/google/protobuf/struct.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ export interface Struct_FieldsEntry {
/**
* `Value` represents a dynamically typed value which can be either
* null, a number, a string, a boolean, a recursive struct value, or a
* list of values. A producer of value is expected to set one of these
* variants. Absence of any variant indicates an error.
* list of values. A producer of value is expected to set one of that
* variants, absence of any variant indicates an error.
*
* The JSON representation for `Value` is JSON value.
*/
Expand Down
10 changes: 1 addition & 9 deletions lib/lib-common/src/models/google/protobuf/timestamp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,15 +53,7 @@ import _m0 from "protobufjs/minimal";
* Timestamp timestamp = Timestamp.newBuilder().setSeconds(millis / 1000)
* .setNanos((int) ((millis % 1000) * 1000000)).build();
*
* Example 5: Compute Timestamp from Java `Instant.now()`.
*
* Instant now = Instant.now();
*
* Timestamp timestamp =
* Timestamp.newBuilder().setSeconds(now.getEpochSecond())
* .setNanos(now.getNano()).build();
*
* Example 6: Compute Timestamp from current time in Python.
* Example 5: Compute Timestamp from current time in Python.
*
* timestamp = Timestamp()
* timestamp.GetCurrentTime()
Expand Down
2 changes: 1 addition & 1 deletion scripts/packages/format.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
#!/usr/bin/env bash

yarn prettier --write src/**/*.ts
yarn prettier --write "src/**/*.ts"