Skip to content

Conversation

@racgoo
Copy link
Contributor

@racgoo racgoo commented Dec 27, 2025

Summary

  • Add 'reflog' feature with tests.

Changes

  • Implement reflog-like methods in 'Repository'
  • Add internal reflog features with 'ReflogEntry'
  • Add test code

Question

@seokju-na I have a small question regarding the error-handling pattern used here (also seen in 'tree.rs' and 'stash.rs').
In 'reflog.get' (reflog.rs:228), the error created by 'ok_or(Error::new(...))' seems to be discarded immediately because the result is converted with '.ok()', collapsing all errors into 'None'.
Since I couldn't find a better approach myself, I wanted to ask whether there is a more idiomatic way to express this without constructing an unused error.

Closes #171

@racgoo racgoo requested a review from seokju-na as a code owner December 27, 2025 11:50
@vercel
Copy link

vercel bot commented Dec 27, 2025

@racgoo is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

reflog

1 participant