feat: add reflog feature with tests #180
Open
+1,052
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Question
@seokju-na I have a small question regarding the error-handling pattern used here (also seen in 'tree.rs' and 'stash.rs').
In 'reflog.get' (reflog.rs:228), the error created by 'ok_or(Error::new(...))' seems to be discarded immediately because the result is converted with '.ok()', collapsing all errors into 'None'.
Since I couldn't find a better approach myself, I wanted to ask whether there is a more idiomatic way to express this without constructing an unused error.
Closes #171